Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename grpc imports #225

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Rename grpc imports #225

merged 1 commit into from
Sep 6, 2019

Conversation

nareddyt
Copy link

@nareddyt nareddyt commented Sep 6, 2019

Needed to be compatible with internal build rules.
So separate out grpc service imports from regular proto imports.

Signed-off-by: Teju Nareddy nareddyt@google.com

Needed to be compatible with internal build rules.

Signed-off-by: Teju Nareddy <nareddyt@google.com>
Copy link
Contributor

@kyessenov kyessenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
For context: Google internal tooling separates go and grpc packages so this double import allows automatic rewrites.

@kyessenov kyessenov merged commit afa22fb into envoyproxy:v2 Sep 6, 2019
@nareddyt nareddyt deleted the v2-grpc-imports branch September 6, 2019 22:28
kyessenov pushed a commit that referenced this pull request Sep 9, 2019
Needed to be compatible with internal build rules.

Signed-off-by: Teju Nareddy <nareddyt@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
kyessenov pushed a commit that referenced this pull request Sep 9, 2019
Needed to be compatible with internal build rules.

Signed-off-by: Teju Nareddy <nareddyt@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants