VHDS Support #529
Merged
VHDS Support #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test pkg to make adding new listeners easier Signed-off-by: mtagstyle <anthony.tran@live.ca>
Signed-off-by: mtagstyle <anthony.tran@live.ca>
|
@mtagstyle would you mind rebase this? I'll start giving it a look |
…into envoyproxy-main Signed-off-by: mtagstyle <anthony.tran@live.ca>
Signed-off-by: mtagstyle <anthony.tran@live.ca>
Sorry for the delay, I've rebased as requested. |
alecholmez
approved these changes
Jan 20, 2022
|
@alecholmez I don't think I have permissions to merge it in. So I leave it at your discretion. |
|
@mtagstyle ah oops sorry, merging! Thanks for working this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow for VHDS to be used in the management server. This is an initial PR and I would appreciate feedback on anything I may not have considered yet (API usage, missing test cases, etc.)
Currently, if the ConfigSource under the VHDS portion is set to anything other than "DELTA_GRPC", Envoy will complain about it not being a supported protocol type. For more information, please refer to #525