Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync/ci: Fix commit #711

Merged
merged 1 commit into from
Jun 4, 2023
Merged

sync/ci: Fix commit #711

merged 1 commit into from
Jun 4, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Jun 4, 2023

No description provided.

@phlax phlax changed the title sync/ci: Fix commit [WIP/TESTING] sync/ci: Fix commit Jun 4, 2023
@phlax phlax marked this pull request as draft June 4, 2023 07:44
@phlax phlax force-pushed the ci-sync-fix-commit branch 3 times, most recently from 2d88e83 to afab748 Compare June 4, 2023 08:21
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the ci-sync-fix-commit branch from afab748 to 617b93a Compare June 4, 2023 08:22
@phlax
Copy link
Member Author

phlax commented Jun 4, 2023

@alecholmez @jpeach not sure why this is not working - it gets a 141 exit code - which is a pipefail from the git command

this doesnt make much sense given that the command is the same as the command above but just with piped output

its quite possible this is some git bug - there are certainly issues like this discussed on the interwebs

i have removed the pipe as it wasnt really necessary, and updated the command - if it fails now we should at least get a bit more information

i have also corrected the bot's commit username/email

@phlax phlax changed the title [WIP/TESTING] sync/ci: Fix commit sync/ci: Fix commit Jun 4, 2023
@phlax phlax marked this pull request as ready for review June 4, 2023 08:26
@phlax phlax merged commit 1a4f6c0 into envoyproxy:main Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants