Use the v2 protobuf module internally. #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's only one place where we use the protobuf APIs, so switch to the v2 protobuf module. This updates envoyproxy#524. Signed-off-by: James Peach <jpeach@apache.org>
sunjayBhatia
approved these changes
Nov 20, 2023
valerian-roche
approved these changes
Nov 20, 2023
Agreed. I'm going to look at moving the generated protos to V2 as well, so maybe we can cut a release after that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's only one place where we use the protobuf APIs, so switch to the v2 protobuf module.
This updates #524.