Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: golangci-lint #993

Merged
merged 5 commits into from
Aug 30, 2024
Merged

fix: golangci-lint #993

merged 5 commits into from
Aug 30, 2024

Conversation

mmorel-35
Copy link
Contributor

  • exclude G115

@mmorel-35
fix: golangci-lint
6f332a9 
- exclude G115

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Update gateway.go
3cdf0c5 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Update server.go
24e92b3 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Update ads.go
0fb916f 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Update ads.go
eed89a4 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 marked this pull request as ready for review August 29, 2024 21:39
valerian-roche
valerian-roche approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@valerian-roche valerian-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, missed listing was broken

@mmorel-35 mmorel-35 merged commit 87f551d into envoyproxy:main Aug 30, 2024
5 checks passed
@mmorel-35 mmorel-35 deleted the fix/golangci-lint branch August 30, 2024 17:11
lukidzi pushed a commit to lukidzi/go-control-plane that referenced this pull request Nov 4, 2024
@mmorel-35 @lukidzi
fix: golangci-lint (envoyproxy#993)
5a86e80 
* fix: golangci-lint

- exclude G115

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valerian-roche valerian-roche valerian-roche approved these changes

@alecholmez alecholmez Awaiting requested review from alecholmez

@zhaohuabing zhaohuabing Awaiting requested review from zhaohuabing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorel-35 @valerian-roche