Skip to content

Commit

Permalink
Relax unnecessarily strict counter assert (#787)
Browse files Browse the repository at this point in the history
Noticed that some runs are failing due to not receiving the expected amount of counters. 

Example:
https://app.circleci.com/pipelines/github/envoyproxy/nighthawk/3411/workflows/4f3cc2a5-8f41-4cf0-b75c-183c63a1eb8d/jobs/31198

Expected 12, Received 14.  The two unaccounted counters are benchmark.pool_overflow and upstream_rq_pending_overflow which is an acceptable outcome of the test. Therefore relaxing test constraints. 

Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
  • Loading branch information
tomjzzhang authored Dec 10, 2021
1 parent c9ae7dc commit b0e35f4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/integration/test_integration_basics.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def test_http_h1(http_test_server_fixture):
asserts.assertEqual(
int(global_histograms["benchmark_http_client.response_header_size"]["raw_pstdev"]), 0)

asserts.assertEqual(len(counters), 12)
asserts.assertGreaterEqual(len(counters), 12)


def _mini_stress_test(fixture, args):
Expand Down Expand Up @@ -191,7 +191,7 @@ def test_http_h2(http_test_server_fixture):
asserts.assertCounterEqual(counters, "upstream_rq_pending_total", 1)
asserts.assertCounterEqual(counters, "upstream_rq_total", 25)
asserts.assertCounterEqual(counters, "default.total_match_count", 1)
asserts.assertEqual(len(counters), 12)
asserts.assertGreaterEqual(len(counters), 12)


def test_http_concurrency(http_test_server_fixture):
Expand Down

0 comments on commit b0e35f4

Please sign in to comment.