Migrate Parameter Parsing: moved configuration of EnzoInitiailFeedbackTest into constructor
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabruzzo
force-pushed
the
param-prototype-initialfeedback-test
branch
from
d1021d1
to
222bf70
Compare
22 tasks
jwise77
approved these changes
May 13, 2024
clairekope
approved these changes
May 13, 2024
Comment on lines
+167
to
168
| // shouldn't we be using a self-consistent mmw? | ||
| const enzo_float mol_weight = enzo::fluid_props()->mol_weight(); |
There was a problem hiding this comment.
I assume this is reading the molecular weight from somewhere else, like another parameter? Maybe make this an issue so we don't loose track of it?
There was a problem hiding this comment.
Yeah, users have the option to specify a single,fixed mmw weight by using the parameter Physics:fluid_props:mol_weight. I added the comment because we go on and subsequently use various species fields.
It doesn't appear that the mmw computed from the species fields will be consistent with the mmw specified in the parameters.
(I'll add this note to the species issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request summary
Followup from #349: moved parameter parsing for
EnzoInitiailFeedbackTestfromEnzoConfiginto constructor.Aside: This sort of migration is the sort of thing that needs to be done for a lot more examples. This is a great first-time-contribution for new developers. I'm going to create an Issue summarizing the process and that links to this PR as an example (in reality, I will probably link to the particular commit that makes this change).