-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute selector values containing # broke in 2.4.0 #495
Comments
In the function
|
fwiw, before releasing or merging anything new, we urgently need to either fix this behavior regression or revert #314. |
Reverting #387 would be easiest if we need an urgent fix, I'm not 100% sure how difficult it's going to be to get this behavior working correctly. That regex is getting unwieldy |
Yes, I think we should. |
Let's keep the test cases tho, skipped. |
Maybe #547 is related to this too? |
@mik01aj I don't think so -- the code that caused this bug was not present in 2.3.0 (as mentioned in the linked ticket). It's possible it's still this regex that's "responsible", though. |
Why was 2.5.0+ released given that it was a regression, and there was earlier talk of reverting the PR that introduced it? |
I think this has slipped through the cracks. When we get a fix in, I'll backport it to both the 2.4.x and 2.5.x lines. |
[Fix] `mount`/`shallow`: fix ID selectors Fixes #495.
v2.4.2, v2.5.2, and v2.6.0 are all now published and all contain this fix. Sorry for the delay! |
[Fix] `mount`/`shallow`: fix ID selectors Fixes #495.
[Fix] `mount`/`shallow`: fix ID selectors Fixes #495.
#314 caused a regression. It broke attribute selectors with values containing
#
, exa[href='/page#anchor']
.Failing test case:
The text was updated successfully, but these errors were encountered: