Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a fluxible guide #533

Closed
wants to merge 1 commit into from
Closed

Adding a fluxible guide #533

wants to merge 1 commit into from

Conversation

jsmey
Copy link

@jsmey jsmey commented Aug 9, 2016

Example of testing Fluxible components

@aweary
Copy link
Collaborator

aweary commented Aug 12, 2016

@jsmey great write up, we really appreciate the effort. I'm not sure we want to include this though; if you look at our current guides we really only provide official guidance on build systems or testing environments. If we added a guide for fluxible, we couldn't really argue against adding it for other misc. libraries (Redux, Relay, Mobx, etc).

I think if anything we'd want to add a guide that addresses the general case of testing HOCs.

@blainekasten
Copy link
Contributor

I agree. This seems like it would be a great blog that you could post on your own! But for the docs I think general guides are better than specifics. That was the goal of #472

@aweary
Copy link
Collaborator

aweary commented Aug 15, 2016

I'm going to close this out then, but I agree with @blainekasten, it'd be a great blog post!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants