Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/leftovers #122

Merged
merged 23 commits into from
Jul 3, 2023
Merged

Fix/leftovers #122

merged 23 commits into from
Jul 3, 2023

Conversation

solovev
Copy link
Contributor

@solovev solovev commented Jul 3, 2023

No description provided.

@solovev solovev requested a review from LeoVS09 July 3, 2023 09:09
@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
farm-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 1:31pm
storybook 🛑 Canceled (Inspect) Jul 3, 2023 1:31pm

switch (action) {
case FormAction.DEPOSIT:
return [walletBalance, walletBalanceBN];
return [wallet, wallet, vault];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, for convenience, it returns current balance based on form state, and other values in bn representation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's later switch to object instead of array, it hard to understand

@LeoVS09 LeoVS09 added the patch label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants