Feature/founders tokens #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implemented ERC5484 with custom modifier
added some tests
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LeoVS09
reviewed
May 18, 2023
|
|
||
| contract VaultFounderTokenMock is VaultFounderToken { | ||
| constructor() initializer { | ||
| __VaultFounderToken_init(3, 120, 200); |
There was a problem hiding this comment.
Make sure it works correctly also with 0 initial price. Better use fuzz testing to set each of this variables
There was a problem hiding this comment.
Could you elaborate how should it work with zero prices, please?
LeoVS09
force-pushed
the
feature/founders-tokens
branch
from
8516f4e
to
39c0d81
Compare
solovev
reviewed
May 20, 2023
| function _priceOf(uint256 tokenId) internal view returns (uint256) { | ||
| uint256 price = _initialTokenPrice; | ||
| for (uint256 i = 0; i < tokenId; i++) { | ||
| price = (price * _nextTokenPriceMultiplier) / 100; |
There was a problem hiding this comment.
can we have a test to check for an overflow?
added role based access to ESBT added mint ESBT to Vault fixed some lint warnings
fixed tests
# Conflicts: # packages/contracts/src/Vault.sol # packages/contracts/test/unit/mocks/VaultMock.sol
merged the latest changes from main branch added code coverage report generation
solovev
reviewed
Jul 1, 2023
solovev
reviewed
Jul 1, 2023
LeoVS09
requested changes
Jul 2, 2023
| /// @dev set vault | ||
| /// @notice that is mandatory to be set before reward can be claimed | ||
| function setVault(Vault vault_) external onlyRole(DEFAULT_ADMIN_ROLE) { | ||
| vault = vault_; |
There was a problem hiding this comment.
VFT cannot do it, but caller can. Just try add _setupRole(BALANCE_UPDATER_ROLE, vault_); it will work.
| /// @dev set vault | ||
| /// @notice that is mandatory to be set before reward can be claimed | ||
| function setVault(Vault vault_) external onlyRole(DEFAULT_ADMIN_ROLE) { | ||
| vault = vault_; |
There was a problem hiding this comment.
Also add there _setupRole(MINTER_ROLE, vault_);
revisited security initialization procedure revisited calculate a next token price logic
|
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
solovev
reviewed
Jul 2, 2023
calc reward logic changed
🐛 fix(RewardHolder.sol): remove redundant initialization code 🐛 fix(VaultFounderToken.sol): remove redundant initialization code and fix logic error in safeMint function ✨ feat(VaultFounderToken.sol): add event to emit founder details when a new token is minted and token price is updated The redundant initialization code in ERC5484Upgradeable.sol and RewardHolder.sol has been removed to improve code readability and reduce redundancy. In VaultFounderToken.sol, the logic error in the safeMint function has been fixed to correctly check if the total supply of tokens has reached the maximum count before minting a new token. Additionally, an event has been added to emit founder details when a new token is minted and the token price is updated. This event will be used to record the price of the current holder token in The Graph.
Fix initialization and optimize code
LeoVS09
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.