[1.0] add get transaction & get transaction receipt from rpc test #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_test_main [1.0->main] add integration test for differen test token
…_0_0-rc1-to-main [1.0 -> main] Bump 1.0.0-rc1 version
…extra-data-to-main [1.0 -> main] Use updated silkworm with the new block-extra-data storage
…_0_0-rc2-to-main [1.0 -> main] Bump 1.0.0-rc2 version
elmato
requested changes
Jun 5, 2024
| bal2 = w3.eth.get_balance(Web3.to_checksum_address("0x9E126C57330FA71556628e0aabd6B6B6783d99fA")) | ||
|
|
||
| # balance different = 1.0 EOS (val) + 900(Gwei) (21000(base gas) + 36782 (gas for non-exist account) ) | ||
| assert(bal1 == bal2 + 1000000000000000000 + 900000000000 * (21000 + 36782)) | ||
|
|
||
| Utils.Print("try to get transaction %s from evm-rpc" % (Web3.to_hex(signed_trx.hash))) | ||
| evm_tx = w3.eth.get_transaction(signed_trx.hash) |
There was a problem hiding this comment.
what happens here if transaction does not exists?
Maybe we can assert that : signed_trx.hash == evm_tx hash
We should also call eth_getTransactionReceipt and do something similar
There was a problem hiding this comment.
Also the PR should start with [1.0] ... and target release/1.0
taokayan
changed the title
elmato
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #229