Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

added eslint and prettier and fixed tests #50

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Conversation

AlexGriffith10
Copy link
Contributor

@AlexGriffith10 AlexGriffith10 commented Mar 28, 2023

Change

updating the node tests so they'll pass, made the PR to merge into another feature branch since they are related but can split into seperate PR (or add to existing one) if that is preferable.

Listing of Commits

c19c428 update node.js so node tests pass
6fba4d7 standardized eslint and prettier configs
4a56bc8 removed BigInt from serialization tests

Listing of Files Changed

.eslintrc
.prettierrc
package-lock.json
package.json
src/eosjs-jsonrpc.ts
src/eosjs-serialize.ts
src/tests/node.js
src/tests/serialization.test.ts
yarn.lock

API Changes

Proof

Screenshot 2023-03-28 at 1 11 42 PM

Fixes

fixes #11

@ericpassmore
Copy link
Contributor

GIT LOGS
c19c428 update node.js so node tests pass
6fba4d7 standardized eslint and prettier configs
4a56bc8 removed BigInt from serialization tests
FILES CHANGED
.eslintrc
.prettierrc
package-lock.json
package.json
src/eosjs-jsonrpc.ts
src/eosjs-serialize.ts
src/tests/node.js
src/tests/serialization.test.ts
yarn.lock

@ericpassmore ericpassmore added the testing infrastructure investing in platform to improve repeatable testing label Mar 28, 2023
@AlexGriffith10 AlexGriffith10 changed the base branch from ehp/GH-11-eslint-config to main March 28, 2023 19:07
@AlexGriffith10 AlexGriffith10 changed the title fix: fix node tests added eslint and prettier and fixed tests Mar 28, 2023
@ericpassmore ericpassmore merged commit 9f6fd23 into main Mar 28, 2023
@ericpassmore ericpassmore deleted the GH-11-fix-node-tests branch April 20, 2023 01:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing infrastructure investing in platform to improve repeatable testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace old eslint config module
2 participants