Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port "Ship delay error fix" test changes #143

Merged
merged 12 commits into from
Apr 28, 2022
Merged

Conversation

spoonincode
Copy link
Member

Ports EOSIO/eos#9175

Added Node methods to analyze production delays, added reporting these at the end of tests, and changed ship_test to only identify as an error when a block is reported as received in the ship node significantly later than when it would have been produced in the producing node (it originally assumed that it was produced at the slot time, which resulted in VM hiccups delaying block production and triggering this error). Also added storing nodeId in the Node so it would not need to be passed in to so many methods.

The change for "storing nodeId in the Node so it would not need to be passed in to so many methods" resolves a lot of conflicts for future ports as it touches a lot of files.

Came over nearly verbatim except for removal of a CI change and removal of change to CFD pruning test

@spoonincode spoonincode marked this pull request as draft April 27, 2022 01:16
@spoonincode spoonincode marked this pull request as ready for review April 27, 2022 02:49
Base automatically changed from test-framework-archiving to main April 28, 2022 16:17
@spoonincode spoonincode merged commit 2ca7a1d into main Apr 28, 2022
@spoonincode spoonincode deleted the ship-delay-error-fix branch April 28, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants