Implemente eos-evm gas-fee (G_codedeposit and G_txnewaccount) #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 21, 2024
elmato
changed the title
yarkinwho
reviewed
Feb 26, 2024
elmato
changed the title
yarkinwho
approved these changes
Mar 5, 2024
| evm_version = _version.has_value() ? *_version : 0; | ||
| } else { | ||
| evm_version = eosevm::nonce_to_version(header.nonce); | ||
| if(protocol_rule_set == protocol::RuleSetType::kTrust) { |
There was a problem hiding this comment.
would it be better to simply panic if anywhere calling this function while not using kTrust?
There was a problem hiding this comment.
We wanted to preserve the old behavior in order to pass the original tests
|
|
||
| } | ||
|
|
||
| evmone::gas_parameters Execution::get_gas_params(const Block& block) const{ |
There was a problem hiding this comment.
Will need tx as argument. and this is the reason why i want to put a cache in block so the config can come for free in some cases.
There was a problem hiding this comment.
Yes, we have the tx passed as argument in the forward function. I will do that in the other PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.