Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clickhouse connect error fix #958

Merged
merged 9 commits into from
Dec 22, 2023
Merged

fix: clickhouse connect error fix #958

merged 9 commits into from
Dec 22, 2023

Conversation

csunny
Copy link
Collaborator

@csunny csunny commented Dec 20, 2023

Close #933

Use clickhouse-connect pylib

pip install clickhouse-connect

@github-actions github-actions bot added the fix Bug fixes label Dec 20, 2023
@csunny
Copy link
Collaborator Author

csunny commented Dec 20, 2023

@Aries-ckt The use of datasource in some places is irregular, such as dbgpt/rag/summary/rdbms_db_summary.py

 columns = []
    for column in conn._inspector.get_columns(table_name):
        if column.get("comment"):
            columns.append(f"{column['name']} ({column.get('comment')})")
        else:
            columns.append(f"{column['name']}")

We should use conn.get_columns(table_name) instead of conn._inspector.get_columns(table_name), the _inspector function is private.

fangyinc
fangyinc previously approved these changes Dec 21, 2023
Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Aries-ckt
Aries-ckt previously approved these changes Dec 21, 2023
Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt requested a review from fangyinc December 21, 2023 12:26
Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@fangyinc fangyinc merged commit 681a8e2 into main Dec 22, 2023
4 checks passed
@csunny csunny deleted the fix_issue_clickhouse branch January 3, 2024 02:49
vshy108 pushed a commit to vshy108/DB-GPT that referenced this pull request Jan 18, 2024
Co-authored-by: Magic <magic@B-4TMH9N3X-2120.local>
Co-authored-by: aries_ckt <916701291@qq.com>
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Co-authored-by: Magic <magic@B-4TMH9N3X-2120.local>
Co-authored-by: aries_ckt <916701291@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

链接Click house数据报错,请各位帮忙看看
3 participants