Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1026 SVG/PNG: Contracted 'Functional Groups' and 'Salts and Solvents' are rendered expanded when saved #1154

Merged
merged 26 commits into from
Jun 23, 2023
Merged

#1026 SVG/PNG: Contracted 'Functional Groups' and 'Salts and Solvents' are rendered expanded when saved #1154

merged 26 commits into from
Jun 23, 2023

Conversation

Wadym
Copy link
Collaborator

@Wadym Wadym commented Jun 6, 2023

No description provided.

@Wadym Wadym self-assigned this Jun 6, 2023
@Wadym Wadym linked an issue Jun 6, 2023 that may be closed by this pull request
SVG/PNG: Contracted 'Functional Groups' and 'Salts and Solvents' are rendered expanded when saved #1026
Closed
@Wadym Wadym marked this pull request as ready for review June 15, 2023 15:42
AlexanderSavelyev
AlexanderSavelyev requested changes Jun 16, 2023
View reviewed changes
core/render2d/src/render_internal.cpp Outdated Show resolved Hide resolved
core/render2d/src/render_internal.cpp Outdated Show resolved Hide resolved
core/render2d/src/render_internal.cpp Outdated Show resolved Hide resolved
@Wadym
Merge branch 'bugfix/1094-r-group_isn_t_opened_correctly_from_v3000' …
852ede5 
…into bugfix/svg_png_contracted_fun_groups_salts_and_solvents_rendered_expanded_saved
@Wadym
cleans and formats
16c888f
@Wadym
cleans
90314ab
Wadym
Wadym commented Jun 22, 2023
View reviewed changes
Copy link
Collaborator Author

@Wadym Wadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all requested changes have been implemented

AlexanderSavelyev
AlexanderSavelyev requested changes Jun 23, 2023
View reviewed changes
core/indigo-core/molecule/molecule.h Outdated Show resolved Hide resolved
core/indigo-core/molecule/multiple_cdx_loader.h Outdated Show resolved Hide resolved
core/indigo-core/molecule/CDXConstants.h Outdated Show resolved Hide resolved
@AlexanderSavelyev AlexanderSavelyev merged commit 17585b2 into master Jun 23, 2023
@AlexanderSavelyev AlexanderSavelyev deleted the bugfix/svg_png_contracted_fun_groups_salts_and_solvents_rendered_expanded_saved branch June 23, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSavelyev AlexanderSavelyev AlexanderSavelyev approved these changes

@even1024 even1024 Awaiting requested review from even1024

Assignees

@Wadym Wadym

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SVG/PNG: Contracted 'Functional Groups' and 'Salts and Solvents' are rendered expanded when saved
2 participants
@Wadym @AlexanderSavelyev