#1191 search molecule using custom index name #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- decrease version of elastic
…61_custom_index_name # Conflicts: # bingo/bingo-elastic/java/pom.xml # bingo/bingo-elastic/java/src/main/java/com/epam/indigo/elastic/ElasticRepository.java
…61_custom_index_name
|
@bodyangug how we would distinguish between “supported” index and any other random index? |
| if index == IndexName.BINGO_REACTION.value: | ||
| return IndigoRecordReaction(elastic_response=response) | ||
| raise AttributeError(f"Unknown index {index}") | ||
| return IndigoRecordMolecule(elastic_response=response) |
There was a problem hiding this comment.
should we raise error if index isn’t really exists?
There was a problem hiding this comment.
That's really hard to track "our" index and other random values because "our" index can be any value that was set up as library-name.
There was a problem hiding this comment.
I have provided some solution, check please.
bodyangug
changed the title
AlexanderSavelyev
changed the title
AlexanderSavelyev
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopen, cause one isuue was found while trying to search at elastic with custom index was recieved error: "Unkown index".
Issue