-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1037 Indigo Toolkit information in the 'About' section that is not relevant for the users #1192
#1037 Indigo Toolkit information in the 'About' section that is not relevant for the users #1192
Conversation
api/c/indigo/src/indigo.cpp
Outdated
@@ -41,6 +42,15 @@ | |||
|
|||
static _SessionLocalContainer<Indigo> indigo_self; | |||
|
|||
static const std::string kVersionInfo = R"({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the place where we need to store this data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please find where the version is created. The string is populated automatically - but not static
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Current output result is number of version: 1.14.0
api/c/indigo/src/indigo.cpp
Outdated
@@ -41,6 +42,15 @@ | |||
|
|||
static _SessionLocalContainer<Indigo> indigo_self; | |||
|
|||
static const std::string kVersionInfo = R"({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please find where the version is created. The string is populated automatically - but not static
I think this task can be done in more straight and clear way:
|
My previous decision was exactly what you proposed, but I got feedback about I shouldn't change *.cmake files and shouldn't add new constants so I have done it through C++ parse string. |
Anyway its was wrong commit - git tag value was not parsed into version vars. |
Requested changes have resolved.
No description provided.