Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1037 Indigo Toolkit information in the 'About' section that is not relevant for the users #1192

Conversation

ghost
Copy link

@ghost ghost commented Jul 21, 2023

No description provided.

@ghost ghost added the Bug label Jul 21, 2023
@ghost ghost self-assigned this Jul 21, 2023
@ghost ghost linked an issue Jul 21, 2023 that may be closed by this pull request
@@ -41,6 +42,15 @@

static _SessionLocalContainer<Indigo> indigo_self;

static const std::string kVersionInfo = R"({
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the place where we need to store this data

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please find where the version is created. The string is populated automatically - but not static

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Current output result is number of version: 1.14.0

@@ -41,6 +42,15 @@

static _SessionLocalContainer<Indigo> indigo_self;

static const std::string kVersionInfo = R"({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please find where the version is created. The string is populated automatically - but not static

@ghost ghost requested a review from AlexanderSavelyev July 24, 2023 17:23
@AliaksandrDziarkach
Copy link
Collaborator

I think this task can be done in more straight and clear way:

  1. Fix api/indigo-version.cmake to set variables for majorVersion, minorVersion, devTag, commitHash
  2. Fix api/c/indigo/src/indigo_version.h.in to define corresponding constants and to define compilerVersion and compilerPlatform.
  3. Add function which combine all this defines into json.

@ghost
Copy link
Author

ghost commented Jul 31, 2023

I think this task can be done in more straight and clear way:

  1. Fix api/indigo-version.cmake to set variables for majorVersion, minorVersion, devTag, commitHash
  2. Fix api/c/indigo/src/indigo_version.h.in to define corresponding constants and to define compilerVersion and compilerPlatform.
  3. Add function which combine all this defines into json.

I think this task can be done in more straight and clear way:

  1. Fix api/indigo-version.cmake to set variables for majorVersion, minorVersion, devTag, commitHash
  2. Fix api/c/indigo/src/indigo_version.h.in to define corresponding constants and to define compilerVersion and compilerPlatform.
  3. Add function which combine all this defines into json.

My previous decision was exactly what you proposed, but I got feedback about I shouldn't change *.cmake files and shouldn't add new constants so I have done it through C++ parse string.

@ghost ghost requested a review from AliaksandrDziarkach July 31, 2023 09:21
@AliaksandrDziarkach
Copy link
Collaborator

3.

My previous decision was exactly what you proposed, but I got feedback about I shouldn't change *.cmake files and shouldn't add new constants so I have done it through C++ parse string.

Anyway its was wrong commit - git tag value was not parsed into version vars.

@ghost ghost requested a review from AlexanderSavelyev July 31, 2023 13:09
@even1024 even1024 removed the request for review from AlexanderSavelyev July 31, 2023 13:11
@ghost ghost dismissed AlexanderSavelyev’s stale review July 31, 2023 13:13

Requested changes have resolved.

@even1024 even1024 merged commit 5bbda74 into master Jul 31, 2023
78 checks passed
@even1024 even1024 deleted the bugfix/1037-indigo-toolkit-information-in-the-about-section-that-is-not-relevant-for-the-users branch July 31, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indigo Toolkit information in the 'About' section that is not relevant for the users
4 participants