Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2303 - Import of variant monomers from Sequence doesn't work for RNA and FASTA for RNA/DNA #2391

Merged
merged 3 commits into from
Sep 17, 2024
Merged

#2303 - Import of variant monomers from Sequence doesn't work for RNA and FASTA for RNA/DNA #2391

merged 3 commits into from
Sep 17, 2024

Conversation

AliaksandrDziarkach
Copy link
Collaborator

Fix code. Update UT

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

For release/xx branch

  • backmerge to master (or newer release/xx) branch is created

@AliaksandrDziarkach
#2303 - Import of variant monomers from Sequence doesn't work for RN…
60af756 
…A and FASTA for RNA/DNA

Fix code. Update UT
@AliaksandrDziarkach AliaksandrDziarkach linked an issue Sep 16, 2024 that may be closed by this pull request
Import of variant monomers from Sequence doesn't work for RNA and FASTA for RNA/DNA #2303
Closed
@AliaksandrDziarkach AliaksandrDziarkach requested review from AlexanderSavelyev and even1024 and removed request for even1024 September 16, 2024 20:01
@AlexanderSavelyev AlexanderSavelyev merged commit 169ffcd into release/1.24 Sep 17, 2024
74 checks passed
@AlexanderSavelyev AlexanderSavelyev deleted the bugfix/2303-broken-import-seq-rna-r branch September 17, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSavelyev AlexanderSavelyev AlexanderSavelyev approved these changes

@even1024 even1024 Awaiting requested review from even1024

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import of variant monomers from Sequence doesn't work for RNA and FASTA for RNA/DNA
2 participants
@AliaksandrDziarkach @AlexanderSavelyev