Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2337 - Export of HELM with inline SMILES contains "Mod0" instead of SMILES #2398

Merged
merged 1 commit into from
Sep 18, 2024
Merged

#2337 - Export of HELM with inline SMILES contains "Mod0" instead of SMILES #2398

merged 1 commit into from
Sep 18, 2024

Conversation

AliaksandrDziarkach
Copy link
Collaborator

Fix code. Update UTs

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

For release/xx branch

  • backmerge to master (or newer release/xx) branch is created

@AliaksandrDziarkach AliaksandrDziarkach linked an issue Sep 17, 2024 that may be closed by this pull request
Export of HELM with inline SMILES contains "Mod0" instead of SMILES #2337
Closed
even1024
even1024 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@even1024 even1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look ok

@AliaksandrDziarkach AliaksandrDziarkach merged commit f7fc224 into release/1.24 Sep 18, 2024
74 checks passed
@AliaksandrDziarkach AliaksandrDziarkach deleted the bugfix/2337-export-helm-smiles-imported-from-helm branch September 18, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@even1024 even1024 even1024 approved these changes

@AlexanderSavelyev AlexanderSavelyev Awaiting requested review from AlexanderSavelyev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export of HELM with inline SMILES contains "Mod0" instead of SMILES
2 participants
@AliaksandrDziarkach @even1024