Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2389 Preview: Margin is not correct for reaction with plus when reaction margin size is changed #2405

Merged
merged 3 commits into from
Sep 19, 2024
Merged

#2389 Preview: Margin is not correct for reaction with plus when reaction margin size is changed #2405

merged 3 commits into from
Sep 19, 2024

Conversation

AliaksandrDziarkach
Copy link
Collaborator

Fix code. Add UT

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

@AliaksandrDziarkach
#2389 Preview: Margin is not correct for reaction with plus when rea…
2e3a681 
…ction margin size is changed

Fix code. Add UT
@AliaksandrDziarkach AliaksandrDziarkach linked an issue Sep 19, 2024 that may be closed by this pull request
Preview: Margin is not correct for reaction with plus when reaction margin size is changed #2389
Closed
even1024
even1024 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@even1024 even1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@AliaksandrDziarkach AliaksandrDziarkach merged commit b97a4a6 into master Sep 19, 2024
74 checks passed
@AliaksandrDziarkach AliaksandrDziarkach deleted the bugfix/2389-wrong-plus-margin branch September 19, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@even1024 even1024 even1024 approved these changes

@AleksandrParamonoff AleksandrParamonoff Awaiting requested review from AleksandrParamonoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preview: Margin is not correct for reaction with plus when reaction margin size is changed
2 participants
@AliaksandrDziarkach @even1024