Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade to es2022 #652

Merged
merged 14 commits into from
Mar 25, 2024
Merged

*: upgrade to es2022 #652

merged 14 commits into from
Mar 25, 2024

Conversation

tharvik
Copy link
Collaborator

@tharvik tharvik commented Mar 19, 2024 •
edited
Loading

move to the current ECMA standard of modules #632

in addition

from a quick test, we can now support importing and using newer library, such as gpt-tokenizer or Transformer.js

@tharvik tharvik force-pushed the 632-upgrade-es2022-tharvik branch 5 times, most recently from 94be14d to b15a411 Compare March 20, 2024 17:47
@tharvik tharvik mentioned this pull request Mar 21, 2024
Merged
@tharvik tharvik force-pushed the 632-upgrade-es2022-tharvik branch from dbde2ea to d3aa368 Compare March 21, 2024 10:30
@tharvik tharvik changed the base branch from develop to 633-bump-node-tharvik March 21, 2024 10:30
@tharvik tharvik self-assigned this Mar 21, 2024
@tharvik tharvik force-pushed the 632-upgrade-es2022-tharvik branch 4 times, most recently from e96988c to b9db50f Compare March 22, 2024 18:56
@tharvik tharvik marked this pull request as ready for review March 22, 2024 19:25
@tharvik tharvik requested a review from JulienVig March 22, 2024 19:28
@JulienVig JulienVig mentioned this pull request Mar 25, 2024
Open
JulienVig
JulienVig approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@JulienVig JulienVig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job thanks for your work!! No blocking comments

tsconfig.base.json Show resolved Hide resolved
discojs/discojs-core/src/aggregator/robust.ts Outdated Show resolved Hide resolved
discojs/discojs-core/src/client/federated/base.ts Show resolved Hide resolved
discojs/discojs-core/src/training/disco.ts Outdated Show resolved Hide resolved
discojs/discojs-core/src/training/disco.ts Outdated Show resolved Hide resolved
discojs/discojs-core/src/weights/aggregation.ts Show resolved Hide resolved
web-client/src/components/training/Trainer.vue Outdated Show resolved Hide resolved
@JulienVig
Copy link
Collaborator

Closes #632, closes #633, closes #634

@JulienVig
Copy link
Collaborator

The PR is merging into 633-bump-node-tharvik rather than develop, is it intentional?

Base automatically changed from 633-bump-node-tharvik to develop March 25, 2024 12:18
@tharvik tharvik force-pushed the 632-upgrade-es2022-tharvik branch from b9db50f to d56b535 Compare March 25, 2024 16:53
@tharvik
Copy link
Collaborator Author

tharvik commented Mar 25, 2024 •
edited
Loading

The PR is merging into 633-bump-node-tharvik rather than develop, is it intentional?

it is! it was based on it and now that #633 is merged, the base branch is automatically changed to "develop".
that's a way to have some kind of linearity in the PRs that I found quite useful.

@tharvik tharvik merged commit 5d282bf into develop Mar 25, 2024
23 checks passed
@tharvik tharvik deleted the 632-upgrade-es2022-tharvik branch March 25, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienVig JulienVig JulienVig approved these changes

@martinjaggi martinjaggi martinjaggi approved these changes

Assignees

@tharvik tharvik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tharvik @JulienVig @martinjaggi