Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommaSeparatedIntegerField Breaks on Non-Integer Input #156

Closed
ephes opened this issue Jun 27, 2024 · 0 comments
Closed

CommaSeparatedIntegerField Breaks on Non-Integer Input #156

ephes opened this issue Jun 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@ephes
Copy link
Owner

ephes commented Jun 27, 2024

Last line of this code:

class CommaSeparatedIntegerField(forms.Field):
    def to_python(self, value: Any | None) -> list[int]:  # Any | None from super -> do not override
        if value is None or not value.strip():
            return []
        return [int(item.strip()) for item in value.split(",")]

Broke on this input: invalid literal for int() with base 10: 'if(now()=sysdate()'

Very funny.

@ephes ephes added the bug Something isn't working label Jun 27, 2024
@ephes ephes self-assigned this Jun 27, 2024
@ephes ephes closed this as completed Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant