V4.34-2 #7
Open
V4.34-2 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the issue but I don't know exactly why it got broken to begin with (#6 (comment)). Did it build in your setup @mark0n ? |
|
4.34-1 builds fine on our CI cluster. If I'm reading your comment correctly this only breaks the RTEMS build. Mark's commit message says the line you are commenting out is related to OPI conversion. I'll give your change a try on Monday. |
|
Do you still need this to be merged or did you find another way to fix the problem? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix Debian build which broke after CONFIG_SITE was included from base in upstream 4.34.