Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn about generation time default #565

Closed
sbfnk opened this issue Feb 21, 2024 · 0 comments · Fixed by #623
Closed

warn about generation time default #565

sbfnk opened this issue Feb 21, 2024 · 0 comments · Fixed by #623
Assignees
@sbfnk
Labels
good first issue Good for newcomers
Milestone
CRAN v1.5 release

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Feb 21, 2024

We set a default generation time of 1 day (fixed). This might be fine for forecasting but does not result in sensible reproduction numbers in almost all cases. Should we warn the user if they are using this default? The warning could be silenced by explicitly setting the generation time to Fixed(1).
@sbfnk sbfnk added the good first issue Good for newcomers label Feb 21, 2024
@sbfnk sbfnk added this to the CRAN v1.5 release milestone Feb 29, 2024
@sbfnk sbfnk self-assigned this Mar 20, 2024
@sbfnk sbfnk mentioned this issue Mar 22, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbfnk sbfnk

Labels
good first issue Good for newcomers
Projects
EpiNow2 v1.5.0
Status: Done
Milestone
CRAN v1.5 release
Development

Successfully merging a pull request may close this issue.

Warn about default generation time options epiforecasts/EpiNow2
1 participant
@sbfnk