Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about default generation time options #623

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Mar 22, 2024

Description

This PR closes #565.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR not done as minor change

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@seabbs seabbs merged commit 9545b8a into main Mar 22, 2024
11 checks passed
@seabbs seabbs deleted the generation_time_opts branch March 22, 2024 11:18
sbfnk added a commit that referenced this pull request May 3, 2024
* add warning about generation time default

* add test

* set default in test
sbfnk added a commit that referenced this pull request May 3, 2024
* add warning about generation time default

* add test

* set default in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warn about generation time default
2 participants