Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort table by hidden numeric columns #265

Merged
merged 1 commit into from
Jul 15, 2021
Merged

sort table by hidden numeric columns #265

merged 1 commit into from
Jul 15, 2021

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jul 14, 2021

@sbfnk sbfnk requested a review from seabbs July 14, 2021 15:41
seabbs
seabbs approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!

@seabbs seabbs merged commit 72cf449 into master Jul 15, 2021
@seabbs seabbs deleted the sort branch July 15, 2021 10:21
@sbfnk
Copy link
Contributor Author

sbfnk commented Jul 15, 2021

Looking at this again makes me think an fread has gone missing in the copy & paste. Will submit another PR.

sbfnk added a commit that referenced this pull request Jul 15, 2021
@sbfnk
Read summary table in report template
3663b50 
Fixes bug introduced in #265
@sbfnk sbfnk mentioned this pull request Jul 15, 2021
Merged
seabbs pushed a commit that referenced this pull request Jul 15, 2021
@sbfnk
Read summary table in report template (#266)
df09f15 
Fixes bug introduced in #265
sbfnk added a commit that referenced this pull request May 3, 2024
@sbfnk
sort table by hidden numeric columns (#265)
4130059
sbfnk added a commit that referenced this pull request May 3, 2024
@sbfnk
Read summary table in report template (#266)
a8f3f09 
Fixes bug introduced in #265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbfnk @seabbs