Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure seeding_time is at least max_gt #275

Merged
merged 3 commits into from
May 5, 2022
Merged

ensure seeding_time is at least max_gt #275

merged 3 commits into from
May 5, 2022

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Oct 8, 2021

Without this there can be initial artefacts when not using delays

seabbs
seabbs reviewed Oct 8, 2021
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Will circle back to this as one failing checks and two not sure this doesn't impact some other uses (like the convolution model) in unintended ways.

@seabbs seabbs merged commit 56caa4e into master May 5, 2022
@seabbs seabbs deleted the initial_period branch May 5, 2022 10:09
sbfnk added a commit that referenced this pull request May 3, 2024
@sbfnk @seabbs
ensure seeding_time is at least max_gt (#275)
012b39a 
* ensure seeding_time is at least max_gt

* fix failing test

Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbfnk @seabbs