-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting #378
Conversation
This is going to mess with ongoing deveopment in open PRs (especially #363) - might be worth waiting for that and then running the linter? |
I did this manually. I am happy to deal with merge issues (also manually) what a dream. I think we need to get the code base in a nice clean place to enable rapid iteration. Having good linting etc will help avoid building in more technical debt. Especially if others are going to make contributions. |
…ed to be resolved
Ah it's fine I'll manage I'm sure. Just might involve some cursing.
Completely agree. |
okay I was not expecting the merge queue to do that... |
I assumed it would wait for checks 😭 |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 9bc622a is merged into main:
|
This is likely not correct and just due to the update to R 4.3.0 and the fact that the entire package cache needed to be rebuilt. |
Adds new linters, adds a changed file only listing action, deals with linting issues across the package (aside from nested
ifelse
- making a help wanted issue), adds an action for rendering the README, cleans up install instructions, goes quietly mad in a corner.