-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce the number of stan models #394
Conversation
I assume you have checked this isn't used? |
Yes - I'm not sure it was ever used, at least I couldn't find a use traversing through git blames. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 5abb62f is merged into main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I think we need a clean depreciation notice here so ideally that would use lifecycle to report that tune_inv_gamma has been deprecated if called. Even more ideally this could give a link to a gist etc where the code still exists (or the git history) and a note saying to let the authors know if using.
Otherwise this is good to go once it has a news update and a Dev version update.
Nice to speed up package compilation!
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 7215bad is merged into main:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 2023b9f is merged into main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 67de94b is merged into main:
|
fixes #393 by combining the models from
dist_fit
into one stan file and ditching the (unused)tune_inv_gamma
model (which could of course be brought back if needed).