Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit touchstone to stan model changes #400

Merged
merged 4 commits into from
Jun 7, 2023
Merged

limit touchstone to stan model changes #400

merged 4 commits into from
Jun 7, 2023

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented May 24, 2023

Fixed #399.

We could add a manual trigger but I'm not sure we'd be able to see the results without being embedded in a PR.

@seabbs
Copy link
Contributor

seabbs commented May 24, 2023

We could add a manual trigger but I'm not sure we'd be able to see the results without being embedded in a PR.

Can we add it to the commit message?

So rather than triggering all the time code is touched only trigger when code is touched and a commit contains [benchmark]? This could be a pain as people will need to know to trigger the benchmark but could be a good option if working on R side code that impacts the stan model?

Or alternatively, change it to look for PR comments but that might be complicated.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 63d8631 is merged into main:

  •   :ballot_box_with_check:default: 59.5s -> 57.5s [-25.54%, +18.95%]
  •   :ballot_box_with_check:no_delays: 48.4s -> 50.6s [-7.14%, +16.49%]
  •   :ballot_box_with_check:random_walk: 14.9s -> 15.7s [-5.98%, +17.37%]
  •   :ballot_box_with_check:stationary: 35.5s -> 36.1s [-4.93%, +8.22%]
  •   :ballot_box_with_check:uncertain: 57.9s -> 55.9s [-15.61%, +8.77%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@sbfnk
Copy link
Contributor Author

sbfnk commented May 27, 2023

These are both great suggestions but I think would either require a separate workflow file or some fairly involved logic inside the workflow body to check whether the benchmark was triggered by a change in stan code or a trigger commit message.

As a simpler solution how about we add a path trigger for a file called e.g. .benchmark which could be temporarily added to a PR to trigger touchstone? We’ll just have to remember to always remove it before merging.

@sbfnk sbfnk marked this pull request as ready for review June 7, 2023 13:27
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

This is how benchmark results would change (along with a 95% confidence interval in relative change) if a4aad24 is merged into main:

  •   :ballot_box_with_check:default: 45.6s -> 48.6s [-11.94%, +24.95%]
  • ❗🐌no_delays: 38.9s -> 42s [+1.07%, +14.91%]
  •   :ballot_box_with_check:random_walk: 12.6s -> 12.4s [-10.7%, +7.15%]
  •   :ballot_box_with_check:stationary: 30.5s -> 32.2s [-4.75%, +16.17%]
  •   :ballot_box_with_check:uncertain: 46.8s -> 47.2s [-12.32%, +14.01%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seabbs seabbs merged commit 02f88a5 into main Jun 7, 2023
@seabbs seabbs deleted the touchstone-trigger branch June 7, 2023 18:11
sbfnk added a commit that referenced this pull request May 3, 2024
* limit touchstone to stan model changes

* add news item and increase dev version

* add manual trigger

* update news item with review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger touchstone only when stan model is changed?
2 participants