Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "initialise vectors to zero" #419

Closed
wants to merge 1 commit into from
Closed

Revert "initialise vectors to zero" #419

wants to merge 1 commit into from

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jul 14, 2023

This reverts commit dcbd3ae.

This is to test whether this commit is behind the current test failures on windows.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if fad4ebb is merged into main:

  • ❗🐌default: 1.07m -> 1.2m [+1.89%, +21.4%]
  • ❗🐌no_delays: 1.05m -> 1.28m [+6.26%, +36.57%]
  •   :ballot_box_with_check:random_walk: 19.9s -> 22.1s [-1.38%, +24.12%]
  •   :ballot_box_with_check:stationary: 40.6s -> 43.6s [-4.66%, +19.22%]
  •   :ballot_box_with_check:uncertain: 1.53m -> 1.64m [-9.65%, +23.82%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@sbfnk
Copy link
Contributor Author

sbfnk commented Jul 17, 2023

This fixed the windows error on first attempt and re-exposed it upon re-running. Might be worth testing again.

@sbfnk sbfnk closed this Jul 20, 2023
@sbfnk sbfnk deleted the revert-speedup branch May 3, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant