Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contribution guide #464

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Improve contribution guide #464

merged 6 commits into from
Oct 12, 2023

Conversation

jamesmbaazam
Copy link
Contributor

@jamesmbaazam jamesmbaazam commented Oct 3, 2023

This PR improves the contribution guide by fleshing out some sections and adding information on pre-compiled vignettes and how to request features and report bugs. It closes #463.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Needs a news item before can merge. Also had a very comments on the contributing guide content.

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @jamesmbaazam!

@sbfnk sbfnk merged commit fab3a80 into main Oct 12, 2023
4 of 9 checks passed
@seabbs seabbs deleted the contrib-guide branch October 12, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain precompiled vignettes in contribution guide
3 participants