Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 701 #717

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Fix 701 #717

merged 4 commits into from
Jul 12, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jul 11, 2024 •
edited
Loading

Description

This PR closes #701.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

seabbs
seabbs previously approved these changes Jul 11, 2024
View reviewed changes
@seabbs seabbs enabled auto-merge (squash) July 11, 2024 18:53
@sbfnk sbfnk merged commit a183a27 into main Jul 12, 2024
9 checks passed
@sbfnk sbfnk deleted the fix-701 branch July 12, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error with fixed delays in estimate_secondary() + forecast_secondary() workflow
2 participants
@sbfnk @seabbs