Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make argument defaults explicit where possible #729

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Make argument defaults explicit where possible #729

merged 3 commits into from
Jul 25, 2024

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Jul 25, 2024

Description

This PR makes some "simple" defaults explicit. This can serve as some form of documentation & simplifies the internal code.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()): not fully passing because of pathfinder issues but it's unrelated to this PR as far as I can tell.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

@seabbs seabbs merged commit 2a626c7 into main Jul 25, 2024
9 checks passed
@seabbs seabbs deleted the arg-defaults branch July 25, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants