Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot distributions with colour instead of line types #788

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

jamesmbaazam
Copy link
Contributor

Description

This PR closes #786 by using the color aesthetic instead of linetype to plot distributions in plot.dist_spec.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

Copy link
Contributor

@sbfnk sbfnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
R/dist_spec.R Show resolved Hide resolved
R/dist_spec.R Outdated Show resolved Hide resolved
sbfnk
sbfnk previously approved these changes Sep 24, 2024
@sbfnk sbfnk added this pull request to the merge queue Sep 24, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 24, 2024
* Plot distributions with color instead of line types

* Add NEWS item

* Use Dark2 palette

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* Add reviewer

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

---------

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
jamesmbaazam and others added 5 commits September 24, 2024 10:31
Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
@jamesmbaazam jamesmbaazam removed this pull request from the merge queue due to a manual request Sep 24, 2024
@jamesmbaazam jamesmbaazam added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit ae825f9 Sep 24, 2024
9 checks passed
@jamesmbaazam jamesmbaazam deleted the color-aes-plot-distspec branch September 24, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add colours to dist_spec plot
2 participants