Updated plot_matrix() function, resolved bug in load_survey and some minor updates. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…provided in "part_age", the min and max age are incorporated in the data table with columns with 'part_age_est_min" and "part_age_est_max" in line with the contact data and the contact_matrix(...) function.
…participant's age can be provided as a range, which previously caused an unsuccessful check in the existing code.
… respect to the 'estimated.participant.age' parameter.
…re the provided files do not include a reference file in JSON format.
* commit '3400e326c01e46261f235e93a686c7ad3cc53a77': remove missing population data add news item Bump JamesIves/github-pages-deploy-action from 4.6.1 to 4.6.4 simplify cleaning of limits
…d fields::imagePlot() function.
…t_matrix()` by using the base `image` function instead. Additionally, the margins of the main plot and the legend were explicitly set within the `plot_matrix()` function. The `fields` package, which contains tools for spatial data, was utilised only for one plotting function.
…timated.participant.age` within the `contact_matrix` function.
…ata with the new option in `contact_matrix`, where either the mean participant data or ranged data should be provided. The code now checks for the actual error message "[X and Y] do not exist," whereas it was previously expecting "[X] does not exist."
…etained after making the matrix symmetric or performing the split procedure.
sbfnk
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Thanks @lwillem, this is great!
Only request for next time is to split different issues into different Pull Requests (i.e. this could be one for the bug, one for the column names, and one for plotting) but anyway it's all good stuff!
|
Okay, thank you. I will do that next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
plot_matrixfunction previously relied on the deprecatedimage.plot()from thefieldspackage, which was only used for a single plotting function. This dependency has now been resolved by switching to the baseimagefunction and explicitly setting the margins for the main plot and the legend within theplot_matrix()function.A bug in
load_survey()has been resolved, which occurred when the provided files did not include a reference file in JSON format.The
check()function has been updated to account for the possibility that the participant's age can be provided as a range. This previously led to unsuccessful checks in the existing code.Additionally, some minor textual changes have been made to the documentation, ensuring that the contact matrix consistently retains
dim.names.