Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing nginx ingress to traefik, use Epinio CLI instead of APIs #65

Merged
merged 7 commits into from
Dec 5, 2023

Conversation

enrichman
Copy link
Member

@enrichman enrichman commented Nov 28, 2023

This PR removes the Nginx ingress to use Traefik only when needed. This will enable Epinio to use the available Traefik on Rancher Desktop.

It also use the epinio CLI instead of the APIs, to avoid problems with the certificates (the CLI will login trusting the self signed certificates.

@enrichman enrichman marked this pull request as ready for review December 5, 2023 11:17
@enrichman enrichman changed the title [WIP] Removing ingress Changing nginx ingress to traefik, use Epinio CLI instead of APIs Dec 5, 2023
@enrichman enrichman self-assigned this Dec 5, 2023
@enrichman enrichman added kind/bug Something isn't working kind/enhancement New feature or request labels Dec 5, 2023
@enrichman enrichman added this to the v1.11.0 milestone Dec 5, 2023
@mmartin24
Copy link
Contributor

Tested on branch and working.
We saw that when Traefik is installed by default it skipped that part and it continues with the install on that point. If it is not installed then it installs it.

The only minor thing is this Docker Desktop warning on it:
image (1)

Approving pr

@mmartin24
Copy link
Contributor

PS: also checked with Docker Desktop:
image

@enrichman enrichman merged commit 520628e into main Dec 5, 2023
2 checks passed
@enrichman enrichman deleted the drop-ingress branch December 5, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants