Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use github token when getting latest release #21

Merged
merged 15 commits into from
Sep 24, 2024
Merged

use github token when getting latest release #21

merged 15 commits into from
Sep 24, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Sep 23, 2024

Description

If this works it would address the issue mentioned in epiforecasts/EpiNow2#769 (comment) - possibly causing the same issue elsewhere?

It tries to do so by sending a github token with the HTTP request to get the latest release version.

I have been able to test the unix version locally but not the windows one.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Two thoughts:

  1. Do we want to make this optional?
  2. Do we want to make this an action input vs using secrets directly? Thinking about how other composite actions work I think this would be more standard?

Once this has merged to propagate I need to bump the rolling version (if this is non-breaking) or make a new rolling version (if this is breaking).

@sbfnk
Copy link
Contributor Author

sbfnk commented Sep 23, 2024

Nice. Two thoughts:

  1. Do we want to make this optional?

You mean something like a use_github_token true/false argument?

  1. Do we want to make this an action input vs using secrets directly? Thinking about how other composite actions work I think this would be more standard?

Can you point me to an example where this is done?

I'll also need to figure out how to actually make this work, and then it might also be better (safer) to just find the environment variable from the script rather than passing it as an argument.

@seabbs
Copy link
Contributor

seabbs commented Sep 23, 2024

I mean if supplied use it and if it's null or not present don't use it.

I'll have a look but limited as on a phone. Maybe codecov is an example?

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good I think will check out in more detail tonight.

@sbfnk
Copy link
Contributor Author

sbfnk commented Sep 23, 2024

I think this is non-breaking now and working except on windows where I don't have access to a good testing environment so am really fishing in the dark

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Agree this looks good and is non breaking will update the rolling release tomorrow.

Windows has been a consistent issue here so not a surprise.

@seabbs seabbs merged commit 06cdac6 into main Sep 24, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants