Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #353: Improvements to logo #361

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Issue #353: Improvements to logo #361

merged 2 commits into from
Oct 2, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Oct 2, 2024

Description

This PR closes #353. It uses the old colour scheme, makes the figure bigger, needs to use whitespace around logo for that reason, gets rid of code that does nothing about fonts.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes requested a review from seabbs October 2, 2024 10:10
@athowes athowes marked this pull request as ready for review October 2, 2024 10:10
@seabbs
Copy link
Contributor

seabbs commented Oct 2, 2024

Can you look into use_logo again? In particular I see these are missing: https://github.com/epinowcast/primarycensoreddist/tree/main/pkgdown/favicon

@seabbs seabbs enabled auto-merge (squash) October 2, 2024 10:14
@athowes
Copy link
Collaborator Author

athowes commented Oct 2, 2024

Can you look into use_logo again? In particular I see these are missing: https://github.com/epinowcast/primarycensoreddist/tree/main/pkgdown/favicon

Done

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

@seabbs seabbs disabled auto-merge October 2, 2024 10:37
@seabbs seabbs merged commit fa03f60 into main Oct 2, 2024
5 checks passed
@seabbs seabbs deleted the better-logo branch October 2, 2024 10:37
@github-actions github-actions bot restored the better-logo branch October 2, 2024 10:38
@athowes athowes deleted the better-logo branch October 14, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve hex sticker
2 participants