Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #374: Add test of input mu ~ 1 as formula #396

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Oct 18, 2024

Description

This PR closes #374.

I think we already had things set up to work fine with formula = mu ~ 1 because epidist_formula is calling:

formula <- brms:::validate_formula(formula, data = data, family = family)

So it already is going to convert from mu ~ 1 to brms::bf.

I added one unit test to check this.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes requested a review from seabbs October 18, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use brms style formula input
1 participant