Provider to nokigiri #124
Merged
Provider to nokigiri #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 12, 2014 15:47
Based upon work from Michael (PR epost-dev#116)
- run unit tests only (not also acceptance tests) - we need nokogiri gem - adopt to new provider (cli) - adopt tests Todo: - correct provider output from xml
|
any chance to get this in prior we start the update to 4.10? |
|
Should i merge this one before PR120 ? |
|
I suggest yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from REXML to Nokogiri
Run only unit tests during normal travis rake task
Adopt PR #116 to all other providers
Add PR #116 and add more spec tests