Fix onevnet provider for dns and network_mask #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter names opennebula expects are DNS and NETWORK_MASK not
dnsservers and netmask, so switch them when writing out the template
to be used when creating the onevnet. (Similar to vlanid to VLAN_ID
already in place.)
Also, the DNS value needs to output a space-separated string.
Also, fix string to array for ruby > 1.9 - when reading in dns from
onevnet list -x need to parse a space separated string. Ruby 1.8 had
a string.to_a but ruby >1.9 doesn't, so use .split(" ") instead (works
on both ruby versions).
jnoss
force-pushed
the
fix_onevnet_provider_for_dns_and_network_mask
branch
from
1f26a94
to
3cd07cf
Compare
|
This is all set and ready for merge. |
|
@tuxmea : please have a look at this, you are the one who wrote the types/providers initially 😄 |
|
looks good to me |
rwaffen
added a commit
that referenced
this pull request
Jul 21, 2015
…etwork_mask Fix onevnet provider for dns and network_mask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the onevnet provider for setting dns and network_mask (parameter names didn't match; also needs to create a space separated array of dns servers). Also fixes an issue with string.to_a for ruby > 1.9.