Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for setting INHERIT_DATASTORE_ATTRs #174

Merged
merged 1 commit into from
Jul 22, 2015

Conversation

jtriley
Copy link
Contributor

@jtriley jtriley commented Jul 22, 2015

This adds support for setting INHERIT_DATASTORE_ATTR settings in oned.conf, e.g.:

one::oned::inherit_datastore_attrs:
  - 'DRIVER'

@jtriley jtriley force-pushed the inherit-datastore-attrs branch 2 times, most recently from a96029e to dc2457e Compare July 22, 2015 15:26
@jtriley
Copy link
Contributor Author

jtriley commented Jul 22, 2015

@rwaffen Tests pass now - FYI existing $hook_scripts iteration in your oned.conf.erb template would fail the same way this PR did provided you didn't specify the setting at all in test.yaml hiera config and you're using ruby >= 1.9. This is due to https://projects.puppetlabs.com/issues/15329. Rather than just add a value to test.yaml hiera I set the default to empty array to avoid this issue for all versions of ruby and puppet.

@rwaffen
Copy link
Contributor

rwaffen commented Jul 22, 2015

oh thanks... sound like problem for not getting "real" booleans out of hiera ... we will check this for our setup... is this a ruby1.9+ only problem?

rwaffen added a commit that referenced this pull request Jul 22, 2015
add support for setting INHERIT_DATASTORE_ATTRs
@rwaffen rwaffen merged commit aaa741a into epost-dev:master Jul 22, 2015
@jtriley jtriley deleted the inherit-datastore-attrs branch July 23, 2015 14:50
@jtriley
Copy link
Contributor Author

jtriley commented Jul 23, 2015

@rwaffen Yep - if you look at the failed builds for this PR you'll see it passes on ruby 1.8.7 for all versions of puppet but fails on all versions of ruby >= 1.9 and all versions of puppet....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants