add onesecgroup provider #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add type and provider for onesecgroup, for the Security Groups new in OpenNebula 4.12
|
Note, the work in progress is in reference to the tests - the type and provider themselves do work, creating, updating, removing onesecgroups in opennebula (Tested in vagrant Centos 7) |
| # | ||
| # Copyright | ||
| # initial provider had no copyright | ||
| # Deutsche Post E-POST Development GmbH - 2014, 2015 |
There was a problem hiding this comment.
maybe you want to update the Copyright and author.
|
I did not run the tests. Looking good for a first merge. We will happily accept patches afterwards. |
|
@tuxmea Comments addressed, this should be ready for merge- Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress type and provider for onesecgroup, for the Security
Groups new in OpenNebula 4.12
/CC @tuxmea let me know what you think