Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying disjoint assemblies #101

Closed
josemduarte opened this issue Apr 7, 2016 · 4 comments
Closed

Displaying disjoint assemblies #101

josemduarte opened this issue Apr 7, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@josemduarte
Copy link
Contributor

Disjoint assemblies are not displayed correctly at the moment. We need a good solution for it. The 2D graph diagrams would definitely help in understanding them.

See original issue #54 for more info

@josemduarte
Copy link
Contributor Author

See also #59

@sbliven sbliven modified the milestones: 3.1, 3.0 Nov 8, 2016
@josemduarte josemduarte modified the milestones: 3.0, 3.1 Dec 8, 2016
@josemduarte
Copy link
Contributor Author

We've got to do something about this for the 3.0 release. Whatever simple solution would do, as long as we display things consistently. Question: are the 2D diagrams output correctly for disjoint assemblies? That would help a lot.

@josemduarte
Copy link
Contributor Author

Answering to my question: the assembly diagrams do display correctly, e.g. a C2, C1 assembly for 4hhb:

4hhb diagram 4 75x75

What needs to be fixed is the assembly thumbnails and perhaps the ngl view.

@josemduarte josemduarte modified the milestones: 3.0.1, 3.0 Mar 17, 2017
@josemduarte josemduarte modified the milestones: 3.0.2, 3.0.1 Apr 7, 2017
@josemduarte josemduarte modified the milestones: 3.0.2, 3.0.3 Sep 18, 2017
josemduarte added a commit that referenced this issue Oct 15, 2017
@josemduarte
Copy link
Contributor Author

I've now fixed the issue with NGL not displaying all chains.

The remaining problem is outputting the different disjoint assemblies to cif file with some sort of separation. The cif file output does contain all chains already, but with no separation between them. It would be nice to introduce some sort of separation so that it is clear that the assembly is disjoint. Once the cif files contain the different disjoint assemblies clearly separated then both thumbnails and ngl views would look ok.

@josemduarte josemduarte modified the milestones: 3.0.3, 3.0.4 Oct 19, 2017
@josemduarte josemduarte modified the milestones: 3.0.4, 3.0.5 Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants