fix: img with missing alt should have role img #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- browsers will treat an image with missing alt as an image. - null alt is different than empty string: empty string removes the node from the AOM, where missing (null) alt does not.
🦋 Changeset is good to goLatest commit: 4bc3983 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ckundo
commented
Sep 21, 2020
| @@ -89,6 +89,7 @@ const cases = [ | |||
| ["html", null, createElementFactory("html", {})], | |||
| ["iframe", null, createElementFactory("iframe", {})], | |||
| ["img with alt=\"some text\"", "img", createElementFactory("img", {alt: "text"})], | |||
| ["img with missing alt", "img", createElementFactory("img", {})], | |||
There was a problem hiding this comment.
per discussion #429 (comment) I think we agree on this behavior @eps1lon?
eps1lon
reviewed
Sep 21, 2020
| @@ -89,6 +89,7 @@ const cases = [ | |||
| ["html", null, createElementFactory("html", {})], | |||
| ["iframe", null, createElementFactory("iframe", {})], | |||
| ["img with alt=\"some text\"", "img", createElementFactory("img", {alt: "text"})], | |||
| ["img with missing alt", "img", createElementFactory("img", {})], | |||
ckundo
commented
Sep 21, 2020
eps1lon
changed the title
|
@ckundo Much appreciated, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alt=''being equivalent.[fixes #429]