Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consider <label /> when computing the accessible name of <output /> #666

Merged
merged 4 commits into from
Jun 2, 2021

Conversation

eps1lon
Copy link
Owner

@eps1lon eps1lon commented Jun 2, 2021

@eps1lon eps1lon added the bug Something isn't working label Jun 2, 2021
@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2021

🦋 Changeset detected

Latest commit: 5246123

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
dom-accessibility-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines -496 to -498
isHTMLInputElement(node) ||
isHTMLSelectElement(node) ||
isHTMLTextAreaElement(node)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an incomplete check whether the node is labelable. However, getLabels already has this check baked in.

@eps1lon eps1lon merged commit 26ee73d into main Jun 2, 2021
@eps1lon eps1lon deleted the fix/output-labelable branch June 2, 2021 11:51
@github-actions github-actions bot mentioned this pull request Jun 2, 2021
@eps1lon eps1lon restored the fix/output-labelable branch January 24, 2022 16:07
@eps1lon eps1lon deleted the fix/output-labelable branch February 23, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant