Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an isDisabled function to identify whether elements are disabled or not #919

Conversation

MatanBobi
Copy link
Contributor

This was discussed in testing-library/dom-testing-library#1221 (comment)

I wasn't sure where's the right place to put this one, please let me know if there's a better place for this and I'll change (I thought about creating a new file but didn't want to make a mess).

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2023

🦋 Changeset detected

Latest commit: 38c8dbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
dom-accessibility-api Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Owner

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seems very much like an implementation detail. I assumed you meant to add a method that checks if an element is considered disabled in the a11y tree.

But this is too low level to be considered for a public API.

@MatanBobi
Copy link
Contributor Author

These seems very much like an implementation detail. I assumed you meant to add a method that checks if an element is considered disabled in the a11y tree.

But this is too low level to be considered for a public API.

That makes a lot more sense.
Will fix this, thanks.

@MatanBobi MatanBobi requested a review from eps1lon March 26, 2023 07:52
@MatanBobi MatanBobi changed the title feat: add a list of elements supporting disabled attribute feat: add an isDisabled function to identify whether elements are disabled or not Mar 28, 2023
@MatanBobi
Copy link
Contributor Author

Hi @eps1lon, pinging you about this change :)
Thanks!

Copy link
Owner

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eps1lon eps1lon merged commit 215955e into eps1lon:main May 7, 2023
@github-actions github-actions bot mentioned this pull request May 7, 2023
@MatanBobi MatanBobi deleted the features/add-elements-supporting-disabled-attribute branch May 8, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants