-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an isDisabled function to identify whether elements are disabled or not #919
feat: add an isDisabled function to identify whether elements are disabled or not #919
Conversation
🦋 Changeset detectedLatest commit: 38c8dbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seems very much like an implementation detail. I assumed you meant to add a method that checks if an element is considered disabled in the a11y tree.
But this is too low level to be considered for a public API.
That makes a lot more sense. |
Hi @eps1lon, pinging you about this change :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This was discussed in testing-library/dom-testing-library#1221 (comment)
I wasn't sure where's the right place to put this one, please let me know if there's a better place for this and I'll change (I thought about creating a new file but didn't want to make a mess).
Thanks!